This repository was archived by the owner on Oct 4, 2019. It is now read-only.
feat(ODC-64): modify GS controller to validate credentials,repository and branch#28
Merged
MatousJobanek merged 1 commit intoredhat-developer:masterfrom Apr 27, 2019
Conversation
alexeykazakov
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the secret is specified in the
GitSourcethen the controller validates:If any of the validation fails, then it sets the appropriate reason as well as the error message.
Every git service implementation uses its own API calls. In case none of the well-known services is matched, then it uses the generic git. Generic git gets only the list of remote branches (same as
git ls-remote)taken from redhat-developer/devconsole-operator#138 as part of ODC-613